Skip to content

build: update bazel dependencies #32983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alan-agius4 merged 1 commit into from
Apr 10, 2026
+19 −89
Merged

build: update bazel dependencies #32983

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 5 additions & 12 deletions MODULE.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,28 +19,21 @@ bazel_dep(name = "aspect_rules_jasmine", version = "2.0.4")
bazel_dep(name = "rules_angular")
git_override(
module_name = "rules_angular",
commit = "6c36180c2efebc6526ef0e6a55a6d738c7de6909",
commit = "46fdabe25ad865093d1be752c778ca4d81f222f5",
remote = "https://github.com/angular/rules_angular.git",
)

bazel_dep(name = "devinfra")
git_override(
module_name = "devinfra",
commit = "ba726e7bca0b08b125ccc6f93c233749e1213c17",
commit = "583cd52fbbadae28ca7a4dd55d63978a984c371a",
remote = "https://github.com/angular/dev-infra.git",
)

bazel_dep(name = "rules_sass")
git_override(
module_name = "rules_sass",
commit = "b5ddaa8e77509bcce35158ad20009636d3da4fbc",
remote = "https://github.com/angular/rules_sass.git",
)

bazel_dep(name = "rules_browsers")
git_override(
module_name = "rules_browsers",
commit = "652b57c41218be318f33fc92032696f53d3aa0ef",
commit = "dc3e432662fe9f99eb7f030a35a22d4ff77d54c7",
remote = "https://github.com/angular/rules_browsers.git",
)

Expand Down Expand Up @@ -177,11 +170,11 @@ use_repo(rules_ts_ext, **{"npm_typescript": "angular_cli_npm_typescript"})

rules_angular = use_extension("@rules_angular//setup:extensions.bzl", "rules_angular")
rules_angular.setup(
name = "components_rules_angular_configurable_deps",
name = "angular_cli_rules_angular_configurable_deps",
angular_compiler_cli = "//:node_modules/@angular/compiler-cli",
typescript = "//:node_modules/typescript",
)
use_repo(rules_angular, **{"rules_angular_configurable_deps": "components_rules_angular_configurable_deps"})
use_repo(rules_angular, **{"rules_angular_configurable_deps": "angular_cli_rules_angular_configurable_deps"})
Comment on lines 172 to +177
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The lock file indicates that both angular_cli_rules_angular_configurable_deps (defined here) and rules_angular_configurable_deps are being generated with identical configurations. The latter is likely coming from a transitive dependency. This duplication is inefficient.

Could you investigate if the generation of the rules_angular_configurable_deps repository can be prevented? This would ensure a single, consistent setup for rules_angular across the project.


register_toolchains(
"@devinfra//bazel/git-toolchain:git_linux_toolchain",
Expand Down
91 changes: 14 additions & 77 deletions MODULE.bazel.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading