build: update bazel dependencies#32983
Conversation
- Update `rules_angular` to `46fdabe25ad865093d1be752c778ca4d81f222f5` - Update `devinfra` to `583cd52fbbadae28ca7a4dd55d63978a984c371a` - Update `rules_browsers` to `dc3e432662fe9f99eb7f030a35a22d4ff77d54c7` - Remove unused `rules_sass` dependency
alan-agius4
added
action: review
angular-robot
bot
added
the
area: build & ci
alan-agius4
added
action: merge
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates several Bazel dependencies, including rules_angular, devinfra, and rules_browsers, while removing rules_sass. It also updates the TypeScript version to 6.0.2 in the lock file. I have identified an inconsistency where the MODULE.bazel file still references the older TypeScript version, and there is a noted duplication in the generated configurable dependencies for rules_angular that should be addressed to ensure a cleaner configuration.
| "version": "6.0.2", | ||
| "integrity": "sha512-bGdAIrZ0wiGDo5l8c++HWtbaNCWTS4UTv7RaTH/ThVIgjkveJt83m74bBHMJkuCbslY8ixgLBVZJIOiQlQTjfQ==", |
There was a problem hiding this comment.
The version of npm_typescript is updated to 6.0.2 here, which is likely due to the dependency updates. However, MODULE.bazel (lines 163-169) explicitly defines and aliases @npm_typescript to use version 5.9.3. This creates an inconsistency between the declared intent and the resolved dependency.
To resolve this, please update the ts_version and ts_integrity in MODULE.bazel to match version 6.0.2 if this is the new intended version. This will make the configuration file consistent with the lock file.
| rules_angular.setup( | ||
| name = "components_rules_angular_configurable_deps", | ||
| name = "angular_cli_rules_angular_configurable_deps", | ||
| angular_compiler_cli = "//:node_modules/@angular/compiler-cli", | ||
| typescript = "//:node_modules/typescript", | ||
| ) | ||
| use_repo(rules_angular, **{"rules_angular_configurable_deps": "components_rules_angular_configurable_deps"}) | ||
| use_repo(rules_angular, **{"rules_angular_configurable_deps": "angular_cli_rules_angular_configurable_deps"}) |
There was a problem hiding this comment.
The lock file indicates that both angular_cli_rules_angular_configurable_deps (defined here) and rules_angular_configurable_deps are being generated with identical configurations. The latter is likely coming from a transitive dependency. This duplication is inefficient.
Could you investigate if the generation of the rules_angular_configurable_deps repository can be prevented? This would ensure a single, consistent setup for rules_angular across the project.
|
This PR was merged into the repository. The changes were merged into the following branches:
|
2 participants
rules_angularto46fdabe25ad865093d1be752c778ca4d81f222f5devinfrato583cd52fbbadae28ca7a4dd55d63978a984c371arules_browserstodc3e432662fe9f99eb7f030a35a22d4ff77d54c7rules_sassdependency