Fix mutable arguments passed as default arguments.#101
Open
roberthdevries wants to merge 2 commits intowolfSSL:masterfrom
Open
Fix mutable arguments passed as default arguments.#101roberthdevries wants to merge 2 commits intowolfSSL:masterfrom
roberthdevries wants to merge 2 commits intowolfSSL:masterfrom
Conversation
roberthdevries
force-pushed
the
fix-passing-mutable-argument-as-default
branch
from
ee90b05 to
786dd94
Compare
Contributor
Author
|
One test case |
JeremiahM37
reviewed
Apr 14, 2026
Contributor
JeremiahM37
left a comment
JeremiahM37
left a comment
There was a problem hiding this comment.
Skoll Code Review
Scan type: review
Overall recommendation: REQUEST_CHANGES
Findings: 2 total — 2 posted, 0 skipped
2 finding(s) posted as inline comments (see file-level comments below)
Posted findings
- [Critical] Use-after-free: EccPrivate.make_key stores dangling RNG pointer when rng=None —
wolfcrypt/ciphers.py:1192-1207 - [Medium] Test does not cover the default rng=None path for EccPrivate.make_key —
tests/test_ciphers.py:616-629
Review generated by Skoll
JeremiahM37
reviewed
Apr 15, 2026
JeremiahM37
previously approved these changes
Apr 15, 2026
dgarske
requested changes
Apr 15, 2026
Contributor
dgarske
left a comment
dgarske
left a comment
There was a problem hiding this comment.
🐺 Skoll Code Review
Overall recommendation: REQUEST_CHANGES
Findings: 2 total — 2 posted, 0 skipped
Posted findings
- [High] EccPrivate.make_key: locally-created RNG freed while ECC key still holds pointer via wc_ecc_set_rng —
wolfcrypt/ciphers.py:1188-1207 - [Medium] No test exercises the default rng=None path for successful EccPrivate.make_key —
tests/test_ciphers.py:616-629
Review generated by Skoll via openclaw
Contributor
|
@roberthdevries please also resolve conflicts. Thanks |
roberthdevries
force-pushed
the
fix-passing-mutable-argument-as-default
branch
from
4f284ed to
a6e9470
Compare
Contributor
Author
|
Conflicts are resolved. |
roberthdevries
force-pushed
the
fix-passing-mutable-argument-as-default
branch
2 times, most recently
from
8066987 to
6a67909
Compare
Function defaults are evaluated once, when the function is defined. The same mutable object is then shared across all calls to the function. If the object is modified, those modifications will persist across calls, which can lead to unexpected behavior.
Add a test for the case where no random number generator is passed to EccPrivate.
roberthdevries
force-pushed
the
fix-passing-mutable-argument-as-default
branch
from
6a67909 to
b4ddce1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Function defaults are evaluated once, when the function is defined.
The same mutable object is then shared across all calls to the function. If the object is modified, those modifications will persist across calls, which can lead to unexpected behavior.