fix[vortex-array]: don't destroy encodings in filter grandchild#7381
Closed
fix[vortex-array]: don't destroy encodings in filter grandchild#7381
Conversation
I believe this is a regression. A Filter(Slice(Ree)) is pretty common and would eagerly canonicalize its child preventing execute_parent kernels like RunEnd's FilterKernel from firing. This is an issue with dict encoding too. This commit executes its child one step so that execute_parent kernels may match. Signed-off-by: Alfonso Subiotto Marques <alfonso.subiotto@polarsignals.com>
Contributor
Author
|
@joseph-isaacs I think this is what I mentioned in our sync and the cause behind seeing filters destroy ree/dict encodings. |
joseph-isaacs
requested changes
Apr 10, 2026
Contributor
joseph-isaacs
left a comment
joseph-isaacs
left a comment
There was a problem hiding this comment.
I will look into this, but this is not the way to do this
Contributor
|
#7386 i think this is the fix. i'll get it merged on monday |
Contributor
Author
|
Closing in favor of #7386 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe this is a regression. A Filter(Slice(Ree)) is pretty common and would eagerly canonicalize its child preventing execute_parent kernels like RunEnd's FilterKernel from firing. This is an issue with dict encoding too.
This commit executes its child one step so that execute_parent kernels may match.
Summary
See above
Testing
Regression test to explicitly verify execute_until result encoding.