feat(editor): add npm.scriptRunner to VS Code settings by jong-kyung · Pull Request #1346 · voidzero-dev/vite-plus

jong-kyung · 2026-04-09T02:48:10Z

Summary

Add "npm.scriptRunner": "vp" to the VSCODE_SETTINGSconstant so that VS Code's NPM Scripts panel runs scripts through vp task runner
Update existing editor config tests with assertions for the new setting
Update IDE integration docs to reflect the new setting

netlify · 2026-04-09T02:48:16Z

✅ Deploy Preview for viteplus-preview canceled.

Name	Link
🔨 Latest commit	`708c0bb`
🔍 Latest deploy log	https://app.netlify.com/projects/viteplus-preview/deploys/69d7cd92c6c6a000082fac68

fengmk2 · 2026-04-09T03:23:16Z

@jong-kyung https://github.com/microsoft/vscode/blob/main/extensions/npm/package.json#L260 Do we need to add a vp enum value here?

jong-kyung · 2026-04-09T03:30:06Z

@jong-kyung https://github.com/microsoft/vscode/blob/main/extensions/npm/package.json#L260 Do we need to add a vp enum value here?

Yes, I think you are right. Since vp is not currently in the allowed enum values for npm.scriptRunner, it definitely needs to be added. I will go ahead and open a PR to microsoft/vscode to add vp first, and I'll let you know here once it's created.

fengmk2 · 2026-04-09T03:32:04Z

I like the goal here, especially for vp create, but I’m not fully convinced this should be a broad default yet.

npm.scriptRunner = "vp" appears to work because VS Code currently treats non-node values as <runner> run <script>. That gives us the intended behavior, but vp is not an officially declared value in the setting schema, so this feels more like relying on current implementation details than using a stable extension point.

My main concern is the repo-level impact: once this lands in .vscode/settings.json, the VS Code NPM Scripts experience now depends on vp being available locally. That seems acceptable for newly created Vite+ projects, but more surprising for migration of existing repos.

So I’d be comfortable with this in create, but I’d prefer migrate to be opt-in, or at least documented very explicitly.

jong-kyung · 2026-04-09T03:49:59Z

I like the goal here, especially for vp create, but I’m not fully convinced this should be a broad default yet.

npm.scriptRunner = "vp" appears to work because VS Code currently treats non-node values as <runner> run <script>. That gives us the intended behavior, but vp is not an officially declared value in the setting schema, so this feels more like relying on current implementation details than using a stable extension point.

My main concern is the repo-level impact: once this lands in .vscode/settings.json, the VS Code NPM Scripts experience now depends on vp being available locally. That seems acceptable for newly created Vite+ projects, but more surprising for migration of existing repos.

So I’d be comfortable with this in create, but I’d prefer migrate to be opt-in, or at least documented very explicitly.

Thanks for the detailed feedback! That makes sense.

I'll update this PR so that npm.scriptRunner: "vp" is only included in vp create, and excluded from vp migrate.
I'll also open an upstream PR to microsoft/vscode to add vp to the npm.scriptRunner enum values so it becomes an officially supported option.

jong-kyung · 2026-04-09T14:29:39Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 637d0e9192

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

packages/cli/src/utils/editor.ts

jong-kyung · 2026-04-09T14:41:49Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f945d8f6b0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

packages/cli/src/create/bin.ts

…d test coverage

jong-kyung · 2026-04-09T14:47:46Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 59cb6dc750

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-04-09T14:52:42Z

packages/cli/src/create/bin.ts

      editorId: selectedEditor,
      interactive: options.interactive,
      silent: compactOutput,
+      extraVsCodeSettings: { 'npm.scriptRunner': 'vp' },


Stop writing unsupported npm.scriptRunner value

Setting npm.scriptRunner to "vp" introduces a workspace setting value that is outside VS Code's npm extension enum (auto, npm, yarn, pnpm, bun, node). In projects created through this path, .vscode/settings.json will be flagged as invalid in editor diagnostics, and users cannot manage this value via the Settings UI; this is a regression in default project hygiene for every VS Code-enabled vp create run.

Useful? React with 👍 / 👎.

jong-kyung · 2026-04-09T15:05:36Z

I've also opened an upstream PR to add vp to the npm.scriptRunner enum in VS Code : microsoft/vscode#308794

feat(editor): add npm.scriptRunner to VS Code settings

964d87a

fengmk2 self-assigned this Apr 9, 2026

feat(editor): limit npm.scriptRunner to vp create only

637d0e9

chatgpt-codex-connector bot reviewed Apr 9, 2026

View reviewed changes

packages/cli/src/utils/editor.ts Outdated Show resolved Hide resolved

fix(editor): restrict additionalSettings to vscode only

3c658fd

chatgpt-codex-connector bot reviewed Apr 9, 2026

View reviewed changes

packages/cli/src/create/bin.ts Outdated Show resolved Hide resolved

refactor(editor): improve extraVsCodeSettings naming, type safety, an…

59cb6dc

…d test coverage

jong-kyung force-pushed the feat/vscode-npm-scriptrunner branch from f945d8f to 59cb6dc Compare April 9, 2026 14:46

chatgpt-codex-connector bot reviewed Apr 9, 2026

View reviewed changes

fengmk2 approved these changes Apr 9, 2026

View reviewed changes

Merge branch 'main' into feat/vscode-npm-scriptrunner

708c0bb

Conversation

jong-kyung commented Apr 9, 2026

Summary

Uh oh!

netlify bot commented Apr 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for viteplus-preview canceled.

Uh oh!

fengmk2 commented Apr 9, 2026

Uh oh!

jong-kyung commented Apr 9, 2026

Uh oh!

fengmk2 commented Apr 9, 2026

Uh oh!

jong-kyung commented Apr 9, 2026

Uh oh!

jong-kyung commented Apr 9, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

jong-kyung commented Apr 9, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

jong-kyung commented Apr 9, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

jong-kyung commented Apr 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

netlify bot commented Apr 9, 2026 •

edited

Loading

jong-kyung commented Apr 9, 2026 •

edited

Loading