Skip to content

toot: update to 0.52.1#59977

Closed
gideonstar-void wants to merge 2 commits intovoid-linux:masterfrom
gideonstar-void:master
Closed

toot: update to 0.52.1#59977
gideonstar-void wants to merge 2 commits intovoid-linux:masterfrom
gideonstar-void:master

Conversation

@gideonstar-void
Copy link
Copy Markdown

Orphan package because old maintainer mail address is not active anymore and the package is outdated.

Orphan package because old maintainer mail address is not active anymore and the package is outdated.
@gideonstar-void
Copy link
Copy Markdown
Author

I tested the changes in this PR: YES

* revision 1
* add python3-pysocks
@ahesford
Copy link
Copy Markdown
Member

For posterity, I note that the orphan action was taken at the request of a core member.

Comment thread srcpkgs/toot/template
python3-urwid python3-urwidgets python3-tomlkit python3-Pillow python3-term-image"
python3-urwid python3-urwidgets python3-tomlkit python3-Pillow python3-term-image
python3-dateutil python3-pysocks"
hostmakedepends="python3-setuptools python3-wheel python3-setuptools_scm ${_depends}"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
hostmakedepends="python3-setuptools python3-wheel python3-setuptools_scm ${_depends}"
hostmakedepends="python3-setuptools python3-wheel python3-setuptools_scm"

Runtime dependencies are almost certainly not required to build, so they should not be listed here. This also means that the _depends variable should go away in favor of just setting depends directly.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm closing this PR right now because I'm lost in git somehow. I'll rework it on a fresh local branch until it's clean. Sorry for the noise, it's my first one ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants