Conversation
valencik
left a comment
There was a problem hiding this comment.
New to using this library so I decided to inspect this a bit more than usual.
This does change the html output of the blog posts using the katex feature.
I ran a build with the current 0.16.28 version and one with this new 0.16.44 and diff'd them:
diff -rq target-katex-28 target-katex-44
Files target-katex-28/blog/equivalence-vs-equality.html and target-katex-44/blog/equivalence-vs-equality.html differ
Files target-katex-28/blog/method-equiv.html and target-katex-44/blog/method-equiv.html differ
Files target-katex-28/blog/minicheck.html and target-katex-44/blog/minicheck.html differ
Files target-katex-28/blog/nested-existentials.html and target-katex-44/blog/nested-existentials.html differ
But the actually differences seem negligible.
The output lines are huge, so awkward to show the diff here, but it's mostly changes like:
> style="margin-right:0.02778em;"
---
< style="margin-right:0.0278em;"Blog posts look like they render the same.
|
|
||
| private def loadKaTeX(): String = { | ||
| val resourcePath = "/META-INF/resources/webjars/katex/0.16.28/dist/katex.js" | ||
| val resourcePath = "/META-INF/resources/webjars/katex/0.16.44/dist/katex.js" |
There was a problem hiding this comment.
Having to update this line as well is annoying.
I wonder if we can get this programmatically without too much difficulty?
There was a problem hiding this comment.
@armanbilge how bad would it be to read the pom.properties at build time? Something like this:
def webjarVersion(artifactId: String): String = {
val propsPath = s"/META-INF/maven/org.webjars.npm/$artifactId/pom.properties"
val props = java.util.Properties()
props.load(classOf[Main.type].getResourceAsStream(propsPath))
props.getProperty("version")
}I get that Scala Steward is smart enough to bump both versions, but I never am when manually doing/testing things.
There was a problem hiding this comment.
Actually, more so than just versioning, we could have a little helper class for loading resources from webjars
There was a problem hiding this comment.
That's a great idea, I think I didn't know about the pom.properties. I issued it :)
c34df2c to
388ac46
Compare
If anyone else is curious, the full diff is in 91cfca8. |
About this PR
📦 Updates org.webjars.npm:katex from
0.16.28to0.16.44📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a
.scala-steward.conffile.Have a fantastic day writing Scala!
🔍 Files still referring to the old version number
The following files still refer to the old version number (0.16.28).
You might want to review and update them manually.
⚙ Adjust future updates
Add this to your
.scala-steward.conffile to ignore future updates of this dependency:Or, add this to slow down future updates of this dependency: