Skip to content

chore: bump workflowcheck asm version for latest JDK version support#2835

Merged
mjameswh merged 1 commit intotemporalio:masterfrom
robzienert:bump-asm
Apr 13, 2026
Merged

chore: bump workflowcheck asm version for latest JDK version support#2835
mjameswh merged 1 commit intotemporalio:masterfrom
robzienert:bump-asm

Conversation

@robzienert
Copy link
Copy Markdown
Contributor

What was changed

Bumps the asm dependency for temporal-workflowcheck to latest.

Why?

The existing dependency only supports up to JDK22, whereas we have uses for JDK24.

Checklist

How was this tested:

./gradlew :temporal-workflowcheck:check

@robzienert robzienert requested a review from a team as a code owner April 9, 2026 23:55
@mjameswh mjameswh merged commit 05ee827 into temporalio:master Apr 13, 2026
16 checks passed
@mjameswh
Copy link
Copy Markdown
Contributor

@robzienert Out of curiosity, are you using workflowcheck's -all build? If not, I think you should be able to get gradle to use a different version of asm.

@robzienert
Copy link
Copy Markdown
Contributor Author

I don't think so - we're just importing temporal-workflowcheck as a dependency and then programmatically calling it. I know I could've just changed the resolved transitive dep, but thought it would be good to fix upstream instead.

@robzienert robzienert deleted the bump-asm branch April 13, 2026 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants