fix: fortran benchmark build of blas/base/dger#11333
Open
DhruvArvindSingh wants to merge 1 commit intostdlib-js:developfrom
Open
fix: fortran benchmark build of blas/base/dger#11333DhruvArvindSingh wants to merge 1 commit intostdlib-js:developfrom
blas/base/dger#11333DhruvArvindSingh wants to merge 1 commit intostdlib-js:developfrom
Conversation
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
Contributor
Author
I was getting the following build error, which got solved once i included the dependencies location within the MakeFile |
7 tasks
kgryte
reviewed
Apr 9, 2026
|
|
||
| # List of Fortran source files: | ||
| SOURCE_FILES ?= ../../src/dger.f | ||
| SOURCE_FILES ?= ../../src/dger.f ../../../xerbla/src/xerbla.f |
Member
There was a problem hiding this comment.
This is not what we want to do. We shouldn't be hardcoding paths of dependencies. This is explicitly what we want to avoid and is why we have dynamic dependency resolution via the manifest.json.
DhruvArvindSingh
pushed a commit
to DhruvArvindSingh/stdlib
that referenced
this pull request
Apr 9, 2026
- Update `compile_fortran_benchmark` script to dynamically resolve Fortran source files (`.f` files) from `manifest.json` using the `@stdlib/utils/library-manifest` utility, similar to how `compile_c_benchmark` resolves C source files - Add `resolve_source_files`, `resolve_libraries`, and `resolve_libpaths` functions to `compile_fortran_benchmark`, matching the structure of `compile_c_benchmark` - Revert `blas/base/dger` Fortran benchmark `Makefile` to remove hardcoded path to `xerbla` dependency; the build script now resolves the dependency via `manifest.json` Closes: stdlib-js#11333 https://claude.ai/code/session_01HHx9iadyJncdYuV1ndGPsk
DhruvArvindSingh
pushed a commit
to DhruvArvindSingh/stdlib
that referenced
this pull request
Apr 9, 2026
- Update `compile_fortran_benchmark` script to dynamically resolve Fortran source files (`.f` files) from `manifest.json` using the `@stdlib/utils/library-manifest` utility, similar to how `compile_c_benchmark` resolves C source files - Add `resolve_source_files`, `resolve_libraries`, and `resolve_libpaths` functions to `compile_fortran_benchmark`, matching the structure of `compile_c_benchmark` - Revert `blas/base/dger` Fortran benchmark `Makefile` to remove hardcoded path to `xerbla` dependency; the build script now resolves the dependency via `manifest.json` Closes: stdlib-js#11333 https://claude.ai/code/session_01HHx9iadyJncdYuV1ndGPsk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Progresses #2039.
Description
This pull request:
Related Issues
This pull request has the following related issues:
Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
{{TODO: add disclosure if applicable}}
@stdlib-js/reviewers