fix: improve Ask view layout adjustment for narrow/split windows#1107
Draft
fix: improve Ask view layout adjustment for narrow/split windows#1107
Conversation
- Add container-width detection using ResizeObserver to detect narrow containers - Automatically switch to vertical layout when container width < 768px - Add toggle button to collapse/expand code references panel - Support both horizontal (wide) and vertical (narrow) layouts - In vertical layout, code references appear below the answer with a collapsible section - In horizontal layout, add ability to collapse the right panel for full-width answer view Fixes issue where code citations become impossible to see in split window mode Co-authored-by: Michael Sukkarieh <msukkari@users.noreply.github.com>
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-authored-by: Michael Sukkarieh <msukkari@users.noreply.github.com>
Remove vertical layout system and toggle button. Instead, simply reduce the minSize from 30% to 20% for both panels, allowing each to shrink more in narrow/split windows without breaking the layout. Co-authored-by: Michael Sukkarieh <msukkari@users.noreply.github.com>
Co-authored-by: Michael Sukkarieh <msukkari@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the Ask view layout issues when the window is in split view mode (e.g., half screen). Previously, the horizontal split layout with code citations would become cramped and hard to use in narrow windows because the minimum panel sizes were too large (30%).
Changes
minSizefor both answer and code references panels from 30% to 20%maxSizefor both panels from 70% to 80%The fix is minimal and focused: it simply allows the resizable panels to shrink more, which prevents the layout from becoming unusable in split window mode.
How to test
Fixes SOU-845
Linear Issue: SOU-845