Skip to content

feat(experiment): add apps.icon.set support for non-hosted app icons#469

Open
srtaalej wants to merge 17 commits intomainfrom
ale-set-icon
Open

feat(experiment): add apps.icon.set support for non-hosted app icons#469
srtaalej wants to merge 17 commits intomainfrom
ale-set-icon

Conversation

@srtaalej
Copy link
Copy Markdown
Contributor

@srtaalej srtaalej commented Apr 3, 2026

Changelog

No user-facing changes until apps.icon.set endpoint is live

Summary

This PR adds IconSet() API method targeting the apps.icon.set endpoint for non-hosted (Bolt) app icons. Gated behind the set-icon experiment flag (--experiment=set-icon) (see Note)

Expected Behavior / Test Plan

slack deploy → updateIcon() uses Icon() (no experiment needed, hosted apps, existing behavior)
slack deploy --experiment set-icon → updateIcon() uses IconSet() (both app types)
slack run --experiment set-icon → InstallLocalApp icon block runs via IconSet() (both app types)
slack run (no experiment) → no icon upload

Migration plan

When apps.icon.set is generally available:

  1. Remove the set-icon experiment gate from updateIcon and InstallLocalApp
  2. Replace all Icon() calls with IconSet()
  3. Delete the deprecated Icon() method, its tests, mock, and the apps.hosted.icon constant

Note

🔴 The apps.icon.set endpoint is available under a toggle. No changes were made to the existing apps.hosted.icon flow.
Required scope (app_configurations:write) may be subject to change before the endpoint goes public

Requirements

@srtaalej srtaalej self-assigned this Apr 3, 2026
@srtaalej srtaalej added enhancement M-T: A feature request for new functionality experiment Experimental feature accessed behind the --experiment flag or toggle semver:patch Use on pull requests to describe the release version increment labels Apr 3, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 3, 2026

Codecov Report

❌ Patch coverage is 26.08696% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.15%. Comparing base (dd3d92e) to head (7b30774).

Files with missing lines Patch % Lines
internal/pkg/apps/install.go 0.00% 16 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #469      +/-   ##
==========================================
- Coverage   71.23%   71.15%   -0.08%     
==========================================
  Files         222      222              
  Lines       18664    18684      +20     
==========================================
  Hits        13295    13295              
- Misses       4189     4207      +18     
- Partials     1180     1182       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@srtaalej srtaalej marked this pull request as ready for review April 6, 2026 22:56
@srtaalej srtaalej requested a review from a team as a code owner April 6, 2026 22:56
@srtaalej srtaalej requested review from mwbrooks and zimeg April 7, 2026 17:07
Copy link
Copy Markdown
Member

@zimeg zimeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐣 A few quick comments and questions and I'm excited to test this next!

@srtaalej srtaalej requested a review from zimeg April 7, 2026 19:41
Copy link
Copy Markdown
Member

@zimeg zimeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@srtaalej Right now I'm not having luck with this when testing in a shared team sandbox and the error isn't so obvious to me...

Let me know if this is something perhaps with the image I use? I'll include it here for testing and other reviewers:

Image

const (
appIconMethod = "apps.hosted.icon"
// appIconSetMethod is the API method for setting app icons for non-hosted apps.
appIconSetMethod = "apps.icon.set"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔬 issue: This outputs a warning to verbose logs and it's not clear what I might not be including?

uploading icon
icon error: https://slack.com/api/apps.icon.set error: missing_arguments
   Error updating app icon: https://slack.com/api/apps.icon.set error: missing_arguments
   Finished in 0.7s

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you uploading through the manifest or is the image just in the root of the project?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@srtaalej I saved this file to the root of the project 🌲 ✨

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the "file" fielf for the api request had the wrong name! can you try again ?

@srtaalej srtaalej marked this pull request as draft April 10, 2026 19:58
@srtaalej srtaalej marked this pull request as ready for review April 13, 2026 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement M-T: A feature request for new functionality experiment Experimental feature accessed behind the --experiment flag or toggle semver:patch Use on pull requests to describe the release version increment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants