Respect MockClient::shouldBypassResponseCache()#18
Open
JonPurvis wants to merge 1 commit intosaloonphp:v3from
Open
Respect MockClient::shouldBypassResponseCache()#18JonPurvis wants to merge 1 commit intosaloonphp:v3from
MockClient::shouldBypassResponseCache()#18JonPurvis wants to merge 1 commit intosaloonphp:v3from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sister PR: saloonphp/saloon#548
Fixes: saloonphp/saloon#547
When a
MockClientopts out viawithoutCache(), the cache middleware should not return a cached fake response or register the cache recorder for that request. Otherwise the first faked response is stored and later sends ignore updated fixtures or mock sequences.CacheMiddlewarenow returns early when the pending request’s mock client reportsshouldBypassResponseCache() === true.Adds feature tests that assert stale fixture behaviour without the opt-out, and fresh fixture reads when
withoutCache()is used on the mock client.