Skip to content

fix: stop exposing client-side tokens#1329

Open
Abhash-Chakraborty wants to merge 1 commit intorecodehive:mainfrom
Abhash-Chakraborty:Abhash/Changes
Open

fix: stop exposing client-side tokens#1329
Abhash-Chakraborty wants to merge 1 commit intorecodehive:mainfrom
Abhash-Chakraborty:Abhash/Changes

Conversation

@Abhash-Chakraborty
Copy link
Copy Markdown
Member

Summary

  • remove the GitHub token from Docusaurus client config and stop sending authenticated GitHub requests from browser code
  • remove the hardcoded Shopify storefront token fallback from site config
  • update the internal documentation to clarify that exposing these values in client-bundled config was a mistake, not an intended design

Testing

  • npm run build
  • npm run typecheck (currently fails on unrelated pre-existing TypeScript errors elsewhere in the repo)

@vercel
Copy link
Copy Markdown
Contributor

vercel bot commented Apr 15, 2026

@Abhash-Chakraborty is attempting to deploy a commit to the recode Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added the recode this is label for leaderboard label Apr 15, 2026
@github-actions
Copy link
Copy Markdown

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. The estimated time for response is 5–8 hrs.

In the meantime, please provide all necessary screenshots and make sure you run - npm build run , command and provide a screenshot, a video recording, or an image of the update you made below, which helps speed up the review and assignment. If you have questions, reach out to LinkedIn. Your contributions are highly appreciated!😊

Note: I maintain the repo issue every day twice at 8:00 AM IST and 9:00 PM IST. If your PR goes stale for more than one day, you can tag and comment on this same issue by tagging @sanjay-kv.

We are here to help you on this journey of open source. Consistent 20 contributions are eligible for sponsorship 💰

🎁 check our list of amazing people we sponsored so far: GitHub Sponsorship. ✨

📚Your perks for contribution to this community 👇🏻

  1. Get free Consultation use code recode50 to get free: Mentorship for free.

  2. Get the Ebook for free use code recode at checkout: Data Science cheatsheet for Beginners.

  3. Check out this weekly Newsletter: Sanjay's Newsletter.

If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

recode this is label for leaderboard

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant