-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
PEP 831: Frame pointers #4896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pablogsal
wants to merge
22
commits into
python:main
Choose a base branch
from
pablogsal:frame-pointers
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
PEP 831: Frame pointers #4896
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
23ea4a5
Frame pointers frame pointers frame pointers
pablogsal 984672f
First pass at edits
savannahostrowski 42c762a
Add ref back
savannahostrowski 2025921
Fix flame graph
savannahostrowski 3408a2b
Fixed whitespace
savannahostrowski 4569c5c
Update preamble
savannahostrowski 6c3bde4
Add RPi and M3 results
savannahostrowski 87a3af7
Clean up table
savannahostrowski 2f241a5
Add my benchmarks
Fidget-Spinner 941880e
Add perf figures, tighten JIT claims
Fidget-Spinner 009204a
remove Diego (for now)
Fidget-Spinner bd948d0
fix typo
Fidget-Spinner 02c94e6
Show outliers
Fidget-Spinner 1c19495
Update pep-0830.rst
Fidget-Spinner 957cecb
Small fixes
pablogsal e7faa8c
Address PR feedback
pablogsal b231f21
Update new results, add alt text
Fidget-Spinner 9360134
exclude svg from pre-commit
Fidget-Spinner c7269af
Update .pre-commit-config.yaml
Fidget-Spinner 42dcac9
Merge pull request #9 from Fidget-Spinner/fp-kj-3
pablogsal df300e1
Apply suggestions from code review
pablogsal 3b8af0a
Apply suggestions
pablogsal File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Fidget-Spinner Did this break the SVGs? They're code, so it's usually okay to allow this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes they break the svgs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait let me correct, I'm not sure if they break it but its very disruptive to reformat svgs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How disruptive? Is it just a one-off automated thing, and then commit and carry one?
If it's a blocker to remove the trailing spaces, please only exclude PEP 831 SVGs.