Skip to content

Add proper lazy deserialization #21198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ilevkivskyi wants to merge 1 commit into
base: master
Choose a base branch
from
+9 −5
Open

Add proper lazy deserialization #21198

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions mypy/nodes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4767,6 +4767,8 @@ class SymbolTableNode:
__slots__ = (
"kind",
"_node",
"_node_bytes",
"_node_tag",
"module_public",
"module_hidden",
"cross_ref",
Expand All @@ -4790,6 +4792,8 @@ def __init__(
) -> None:
self.kind = kind
self._node = node
self._node_bytes = b""
self._node_tag: Tag = 0
self.module_public = module_public
self.implicit = implicit
self.module_hidden = module_hidden
Expand Down Expand Up @@ -4824,6 +4828,9 @@ def node(self) -> SymbolNode | None:
if self.cross_ref is not None:
node_fixer.resolve_cross_ref(self)
else:
if self._node is None:
self._node = read_symbol(ReadBuffer(self._node_bytes), self._node_tag)
self._node_bytes = b""
node = self._node
assert node is not None
if self.stored_info is not None:
Expand Down Expand Up @@ -4958,11 +4965,8 @@ def read(cls, data: ReadBuffer) -> SymbolTableNode:
if tag == TYPE_INFO:
sym._node = TypeInfo.read(data)
else:
# This logic is temporary, to make sure we don't introduce
# regressions until we have proper lazy deserialization.
# It has negligible performance impact.
node_bytes = extract_symbol(data)
sym._node = read_symbol(ReadBuffer(node_bytes), tag)
sym._node_bytes = extract_symbol(data)
sym._node_tag = tag
sym.unfixed = True
else:
sym.cross_ref = cross_ref
Expand Down
Loading