gh-148438: implement _RECORD_BOUND_METHOD in JIT#148457
gh-148438: implement _RECORD_BOUND_METHOD in JIT#148457Fidget-Spinner merged 7 commits intopython:mainfrom
_RECORD_BOUND_METHOD in JIT#148457Conversation
|
Uh, didn't realise cpython/Python/optimizer_analysis.c Lines 623 to 627 in 03d2f03 |
Fidget-Spinner
left a comment
There was a problem hiding this comment.
Very close, thanks. Some tricky bits that I explain below.
Python/optimizer_bytecodes.c
Outdated
There was a problem hiding this comment.
We can one-up this. If it's a probable constant callable, and the func_version matches, we can promote the callable to a known one, just like you did in_CHECK_METHOD_VERSION .
Also, heads up I'm merging my PR https://github.com/python/cpython/pull/146300/changes because _CHECK_FUNCTION_VERSION is wrong for the first if case.
There was a problem hiding this comment.
Oops sorry, my other PR's change does the same thing now to fix this. Sorry, please undo the change here and then I'll land my PR!
|
Done. Will sort conflicts once #146300 is in. Really appreciate the review, cheers |
_RECORD_BOUND_METHODrecords method object now, so_EXACT_ARGSneeds to extractim_funcout of it as well.