Skip to content

gh-145742: Manually emit _LOAD_FAST_BORROW to reduce stencil bloat #148217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
corona10 wants to merge 7 commits into
base: main
Choose a base branch
from
Open

gh-145742: Manually emit _LOAD_FAST_BORROW to reduce stencil bloat #148217

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c6fa882
gh-145742: Manually emit _LOAD_FAST_BORROW to reduce stencil bloat
corona10 Apr 7, 2026
e24e176
Support i686
corona10 Apr 8, 2026
d459f5e
Merge remote-tracking branch 'upstream/main' into gh-145742-impl
corona10 Apr 8, 2026
a08df36
Merge remote-tracking branch 'upstream/main' into gh-145742-impl
corona10 Apr 11, 2026
e0cf241
Address code review
corona10 Apr 12, 2026
7957e62
Generate fallback for aarch64
corona10 Apr 12, 2026
bbf847f
fix for aarch64
corona10 Apr 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2,050 changes: 1,009 additions & 1,041 deletions Include/internal/pycore_uop_ids.h
View file
Open in desktop

Large diffs are not rendered by default.

153 changes: 0 additions & 153 deletions Include/internal/pycore_uop_metadata.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Lib/test/test_capi/test_opt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ def testfunc(x):
self.assertIsNotNone(ex)
uops = get_opnames(ex)
self.assertIn("_JUMP_TO_TOP", uops)
self.assertIn("_LOAD_FAST_BORROW_0", uops)
self.assertIn("_LOAD_FAST_BORROW", uops)

def test_extended_arg(self):
"Check EXTENDED_ARG handling in superblock creation"
Expand Down
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Core_and_Builtins/2026-04-07-22-44-02.gh-issue-145742.ZRmmO3.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Manually emit _LOAD_FAST_BORROW and remove replicate(8). Patch by Donghee
Na.
2 changes: 1 addition & 1 deletion Python/bytecodes.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,7 @@ dummy_func(
value = PyStackRef_DUP(GETLOCAL(oparg));
}

replicate(8) pure inst (LOAD_FAST_BORROW, (-- value)) {
pure inst(LOAD_FAST_BORROW, (-- value)) {
assert(!PyStackRef_IsNull(GETLOCAL(oparg)));
value = PyStackRef_Borrow(GETLOCAL(oparg));
}
Expand Down
Loading
Loading