gh-146563: add exception note for invalid Expat handler return values#146565
Open
picnixz wants to merge 6 commits intopython:mainfrom
Open
gh-146563: add exception note for invalid Expat handler return values#146565picnixz wants to merge 6 commits intopython:mainfrom
picnixz wants to merge 6 commits intopython:mainfrom
Conversation
picnixz
commented
Mar 28, 2026
Misc/NEWS.d/next/Library/2026-03-28-11-31-32.gh-issue-146563.cXtSym.rst
Outdated
Show resolved
Hide resolved
picnixz
commented
Mar 28, 2026
picnixz
commented
Mar 28, 2026
encukou
reviewed
Apr 7, 2026
picnixz
commented
Apr 11, 2026
| { | ||
| PyObject *exc = PyErr_GetRaisedException(); | ||
| assert(exc != NULL); | ||
| PyObject *note = PyUnicode_FromFormat("invalid '%s' event handler return value", name); |
Member
Author
There was a problem hiding this comment.
@encukou Do you have a better wording for this? maybe we should say "expecting X and not Y" ? as it's invoked from a macro I can add more arguments if necessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.