Strip leading @ from InvalidTag name#458
Open
lacatoire wants to merge 1 commit intophpDocumentor:6.xfrom
Open
Conversation
Tag names are normally exposed without their leading "@", but when an InvalidTag is built from the name PHPStan's phpdoc-parser advertises (e.g. for a malformed `@var $self SomeClass`), the name is passed through as-is and `getName()` ends up returning "@var" instead of "var". Normalizing the name at the single entry point (`InvalidTag::create`) keeps the behaviour consistent with every other tag in the library regardless of the upstream parser's convention. Fixes phpDocumentor#449
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tag names are normally exposed without their leading
@, but when anInvalidTagis built from the name PHPStan's phpdoc-parser advertises (e.g. for a malformed@var $self SomeClass), the name is passed through as-is andgetName()ends up returning@varinstead ofvar. Normalizing the name at the single entry point (InvalidTag::create) keeps the behaviour consistent with every other tag in the library regardless of the upstream parser's convention.Fixes #449