Allow balanced braces inside inline tag descriptions#455
Open
lacatoire wants to merge 2 commits intophpDocumentor:6.xfrom
Open
Allow balanced braces inside inline tag descriptions#455lacatoire wants to merge 2 commits intophpDocumentor:6.xfrom
lacatoire wants to merge 2 commits intophpDocumentor:6.xfrom
Conversation
The inline-tag tokenizer used in DescriptionFactory recognised nested inline tags and hanging '{', but not a bare balanced pair such as '{braces}' used as part of an inline tag body. Matching such a pair now preserves the surrounding inline tag instead of truncating it at the first closing brace.
Refs phpDocumentor#255
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The inline-tag tokenizer in
DescriptionFactory::lexrecognised nested inline tags and hanging{, but a bare balanced pair such as{braces}inside an inline tag body made the outer tag truncate at the first closing brace. The tokenizer now accepts a balanced{...}pair alongside the existing alternatives.Fixes #255