Simplify gh21031.phpt and solve flakiness#21692
Open
iluuu1994 wants to merge 1 commit intophp:PHP-8.4from
Open
Simplify gh21031.phpt and solve flakiness#21692iluuu1994 wants to merge 1 commit intophp:PHP-8.4from
iluuu1994 wants to merge 1 commit intophp:PHP-8.4from
Conversation
stream_socket_accept($server, 3) would frequently run into a race-condition where the call would timeout and return false, triggering an exception when calling fclose(false) and terminating the process. This would break the phpt_notify() call in the main process due to a broken pipe. Increase the timeout to solve this. Furthermore, remove the proxy in the test that is not necessary to trigger the original bug solved in 7782b88.
iluuu1994
force-pushed
the
fix-flaky-gh21031-test
branch
from
41fd5d0 to
9579e72
Compare
ndossche
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
stream_socket_accept($server, 3) would frequently run into a race-condition where the call would timeout and return false, triggering an exception when calling fclose(false) and terminating the process. This would break the phpt_notify() call in the main process due to a broken pipe. Increase the timeout to solve this.
Furthermore, remove the proxy in the test that is not necessary to trigger the original bug solved in 7782b88.
For context: https://github.com/php/php-src/actions/runs/24167977131/job/70533618981 There were many such failures in the last few days.