Fix GH-21683: Handle empty result set in single-row mode#21684
Open
thomasschiet wants to merge 1 commit intophp:PHP-8.5from
Open
Fix GH-21683: Handle empty result set in single-row mode#21684thomasschiet wants to merge 1 commit intophp:PHP-8.5from
thomasschiet wants to merge 1 commit intophp:PHP-8.5from
Conversation
Member
|
Hi @thomasschiet since it s a fix, it needs to target the lowest branch it applies to (i.e. PHP-8.5 or PHP-8.4 ?). |
thomasschiet
requested review from
DanielEScherzer,
Girgias,
NattyNarwhal,
TimWolla,
adoy,
alexdowad,
arnaud-lb,
bukka,
derickr,
dstogov,
kamil-tekiela,
kocsismate,
ndossche,
youkidearitai and
zeriyoshi
as code owners
devnexen
removed request for
NattyNarwhal,
TimWolla,
adoy,
alexdowad,
arnaud-lb,
bukka,
derickr,
dstogov,
kocsismate and
youkidearitai
devnexen
removed request for
DanielEScherzer,
Girgias,
kamil-tekiela,
ndossche and
zeriyoshi
Member
|
as mentioned in your report, it looks correct at first glance I ll have a better look sometime today. Thanks ! |
thomasschiet
force-pushed
the
fix/pgsql-single-row-mode-empty-table
branch
from
a8de9d3 to
5923d7d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21683 by checking if
PQgetResultreturnsNULL.