Skip to content

🐛 Fix DNS1123 validation message to match rule semantics #2652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-bot merged 1 commit into from
Apr 15, 2026
Merged

🐛 Fix DNS1123 validation message to match rule semantics #2652

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions api/v1/clusterobjectset_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,7 +366,7 @@ type ClusterObjectSetPhase struct {
// +required
// +kubebuilder:validation:MinLength=1
// +kubebuilder:validation:MaxLength=63
// +kubebuilder:validation:XValidation:rule=`!format.dns1123Label().validate(self).hasValue()`,message="the value must consist of only lowercase alphanumeric characters and hyphens, and must start with an alphabetic character and end with an alphanumeric character."
// +kubebuilder:validation:XValidation:rule=`!format.dns1123Label().validate(self).hasValue()`,message="the value must consist of only lowercase alphanumeric characters and hyphens, and must start and end with an alphanumeric character."
Name string `json:"name"`

// objects is a required list of all Kubernetes objects that belong to this phase.
Expand Down Expand Up @@ -532,7 +532,7 @@ type ObservedPhase struct {
// +required
// +kubebuilder:validation:MinLength=1
// +kubebuilder:validation:MaxLength=63
// +kubebuilder:validation:XValidation:rule=`!format.dns1123Label().validate(self).hasValue()`,message="the value must consist of only lowercase alphanumeric characters and hyphens, and must start with an alphabetic character and end with an alphanumeric character."
// +kubebuilder:validation:XValidation:rule=`!format.dns1123Label().validate(self).hasValue()`,message="the value must consist of only lowercase alphanumeric characters and hyphens, and must start and end with an alphanumeric character."
Name string `json:"name"`

// digest is the digest of the phase's resolved object content
Expand Down
8 changes: 4 additions & 4 deletions ...base/operator-controller/crd/experimental/olm.operatorframework.io_clusterobjectsets.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,8 +150,8 @@ spec:
type: string
x-kubernetes-validations:
- message: the value must consist of only lowercase alphanumeric
characters and hyphens, and must start with an alphabetic
character and end with an alphanumeric character.
characters and hyphens, and must start and end with an alphanumeric
character.
rule: '!format.dns1123Label().validate(self).hasValue()'
objects:
description: |-
Expand Down Expand Up @@ -649,8 +649,8 @@ spec:
type: string
x-kubernetes-validations:
- message: the value must consist of only lowercase alphanumeric
characters and hyphens, and must start with an alphabetic
character and end with an alphanumeric character.
characters and hyphens, and must start and end with an alphanumeric
character.
rule: '!format.dns1123Label().validate(self).hasValue()'
required:
- digest
Expand Down
8 changes: 4 additions & 4 deletions manifests/experimental-e2e.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1474,8 +1474,8 @@ spec:
type: string
x-kubernetes-validations:
- message: the value must consist of only lowercase alphanumeric
characters and hyphens, and must start with an alphabetic
character and end with an alphanumeric character.
characters and hyphens, and must start and end with an alphanumeric
character.
rule: '!format.dns1123Label().validate(self).hasValue()'
objects:
description: |-
Expand Down Expand Up @@ -1973,8 +1973,8 @@ spec:
type: string
x-kubernetes-validations:
- message: the value must consist of only lowercase alphanumeric
characters and hyphens, and must start with an alphabetic
character and end with an alphanumeric character.
characters and hyphens, and must start and end with an alphanumeric
character.
rule: '!format.dns1123Label().validate(self).hasValue()'
required:
- digest
Expand Down
8 changes: 4 additions & 4 deletions manifests/experimental.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1435,8 +1435,8 @@ spec:
type: string
x-kubernetes-validations:
- message: the value must consist of only lowercase alphanumeric
characters and hyphens, and must start with an alphabetic
character and end with an alphanumeric character.
characters and hyphens, and must start and end with an alphanumeric
character.
rule: '!format.dns1123Label().validate(self).hasValue()'
objects:
description: |-
Expand Down Expand Up @@ -1934,8 +1934,8 @@ spec:
type: string
x-kubernetes-validations:
- message: the value must consist of only lowercase alphanumeric
characters and hyphens, and must start with an alphabetic
character and end with an alphanumeric character.
characters and hyphens, and must start and end with an alphanumeric
character.
rule: '!format.dns1123Label().validate(self).hasValue()'
required:
- digest
Expand Down
Loading