fix: deprecated diagnostic jumping config

[nathanzeng]

opts.jump.float is deprecated as of the 0.12 release. To confirm, use the kickstart config and run:
:checkhealth vim.deprecated

• ⚠️ WARNING opts.jump.float is deprecated. Feature will be removed in Nvim 0.14
  • ADVICE:
    • use opts.jump.on_jump instead.

This also bumps the minimum version to 0.12

[oriori1703]

Because this uses a feature (on_jump) that was added in 0.12 you should also bump the version in lua/kickstart/health.lua.

On a related note, should we wait a bit before dropping support for 0.11?
I know a lot of people get Neovim from their distro’s package manager, and most distros haven’t updated to 0.12 yet.

Both Ubuntu and Fedora are releasing new versions this month, and I assume they’ll include 0.12. Should we wait until those releases?

(Mostly thinking out loud - though I would love to hear others' opinion)

[nathanzeng]

Thanks for the review, and good catch on bumping the health check. Waiting for Ubuntu and Fedora seems like a good idea to me.

[oriori1703]

LGTM :)
Will merge once we drop support for 0.11

[oriori1703]

After checking fedora and ubuntu it seems both of them won't include 0.12 in their upcoming versions (at least at release).

https://packages.fedoraproject.org/pkgs/neovim/neovim/ (reason seems to be this)

https://packages.ubuntu.com/resolute/neovim (my guess is because debian-testing didn't update either).

Maybe we should reconsider the timeline of dropping support.

[nathanzeng]

I'm not sure if you mean dropping support earlier or later, but I think either is fine.

For what it's worth I think the readme for kickstart does a great job of explaining that only the latest version of neovim is supported, and pointing you to how to install it.

[oriori1703]

Considering it seems like the big distros won't update to 0.12 anytime soon, I think it fine to drop support earlier.

Though I think fixing a deprecation warning is not a big enough reason to do that.
A good time will probably be if (or when) we are going to use any of the new features suggested in #1971

[agopalareddy]

I reproduced this locally on Neovim 0.12.1 with a fresh Kickstart-based setup.

:checkhealth vim.deprecated reported the opts.jump.float deprecation warning for the current config, and switching to the jump.on_jump callback form cleared that warning in my verification.

I also ended up needing the explicit float options (bufnr = bufnr, scope = 'cursor', focus = false) to match the previous behavior, so the current shape of this PR looks right to me from a compatibility/verification standpoint.

The only real open question I see is the repo's 0.11 support timeline, not the implementation itself.