test: generate localstorage-file in a temp dir#62660
Open
legendecas wants to merge 2 commits intonodejs:mainfrom
Open
test: generate localstorage-file in a temp dir#62660legendecas wants to merge 2 commits intonodejs:mainfrom
legendecas wants to merge 2 commits intonodejs:mainfrom
Conversation
cjihrig
approved these changes
Apr 9, 2026
aduh95
approved these changes
Apr 9, 2026
Contributor
|
Fast-track has been requested by @aduh95. Please 👍 to approve. |
Collaborator
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #62660 +/- ##
==========================================
+ Coverage 89.79% 89.81% +0.02%
==========================================
Files 699 699
Lines 216163 216235 +72
Branches 41327 41333 +6
==========================================
+ Hits 194110 194218 +108
+ Misses 14173 14131 -42
- Partials 7880 7886 +6 🚀 New features to boost your workflow:
|
richardlau
approved these changes
Apr 9, 2026
Member
|
The test fails when the test runner is run with |
avivkeller
approved these changes
Apr 10, 2026
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #62646