Closed
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
dependencies
jasnell
approved these changes
Mar 22, 2026
anonrig
approved these changes
Mar 22, 2026
legendecas
added
dont-land-on-v20.x
This comment was marked as spam.
This comment was marked as spam.
RafaelGSS
reviewed
Mar 24, 2026
Member
RafaelGSS
left a comment
RafaelGSS
left a comment
There was a problem hiding this comment.
It's missing adding update-perfetto.sh to workflows/tools.yml and adding nodejs/diagnostics as codeowner of this updater.
Member
Author
|
@RafaelGSS I didn't add the workflow because there is no CI covering the build. I plan to add the workflow automate the update when V8 changes landed and with CI setup. |
github-actions
bot
removed
the
request-ci
Collaborator
joyeecheung
approved these changes
Mar 26, 2026
Collaborator
Collaborator
Collaborator
legendecas
added
the
author ready
avivkeller
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/62397 ✔ Done loading data for nodejs/node/pull/62397 ----------------------------------- PR info ------------------------------------ Title deps: add perfetto sdk (#62397) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch legendecas:perfetto-sdk -> nodejs:main Labels tools, author ready, needs-ci, dependencies, dont-land-on-v20.x, dont-land-on-v22.x, dont-land-on-v24.x, dont-land-on-v25.x Commits 3 - deps: add perfetto build files - tools: add perfetto updater - deps: update perfetto to 54.0 Committers 1 - Chengzhong Wu <legendecas@gmail.com> PR-URL: https://github.com/nodejs/node/pull/62397 Refs: https://github.com/nodejs/diagnostics/issues/654 Refs: https://issues.chromium.org/issues/457135433 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/62397 Refs: https://github.com/nodejs/diagnostics/issues/654 Refs: https://issues.chromium.org/issues/457135433 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 22 Mar 2026 19:09:05 GMT ✔ Approvals: 4 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/62397#pullrequestreview-3988575643 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/62397#pullrequestreview-3988649093 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/62397#pullrequestreview-3990158875 ✔ - Joyee Cheung (@joyeecheung) (TSC): https://github.com/nodejs/node/pull/62397#pullrequestreview-4010914467 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2026-04-01T14:53:38Z: https://ci.nodejs.org/job/node-test-pull-request/72388/ - Querying data for job/node-test-pull-request/72388/ ✔ Build data downloaded ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 62397 From https://github.com/nodejs/node * branch refs/pull/62397/merge -> FETCH_HEAD ✔ Fetched commits as e6ef4774c202..efdce9a74e10 -------------------------------------------------------------------------------- [main 6304553d8c] deps: add perfetto build files Author: Chengzhong Wu <legendecas@gmail.com> Date: Sun Mar 22 14:56:02 2026 -0400 4 files changed, 59 insertions(+) create mode 100644 deps/perfetto/BUILD.gn create mode 100644 deps/perfetto/VERSION create mode 100644 deps/perfetto/perfetto.gyp create mode 100644 deps/perfetto/unofficial.gni [main b3b488e6a1] tools: add perfetto updater Author: Chengzhong Wu <legendecas@gmail.com> Date: Sun Mar 22 14:49:41 2026 -0400 2 files changed, 82 insertions(+) create mode 100755 tools/dep_updaters/update-perfetto.sh [main 4b09ab3281] deps: update perfetto to 54.0 Author: Chengzhong Wu <legendecas@gmail.com> Date: Sun Mar 22 14:56:37 2026 -0400 4 files changed, 279764 insertions(+), 1 deletion(-) create mode 100644 deps/perfetto/LICENSE create mode 100644 deps/perfetto/sdk/perfetto.cc create mode 100644 deps/perfetto/sdk/perfetto.h ✔ Patches applied There are 3 commits in the PR. Attempting autorebase. (node:997) [DEP0190] DeprecationWarning: Passing args to a child process with shell option true can lead to security vulnerabilities, as the arguments are not escaped, only concatenated. (Use `node --trace-deprecation ...` to show where the warning was created) Rebasing (2/6) Executing: git node land --amend --yes --------------------------------- New Message ---------------------------------- deps: add perfetto build fileshttps://github.com/nodejs/node/actions/runs/24207909791 |
avivkeller
added
the
commit-queue
avivkeller
added
the
commit-queue-rebase
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in f01f79e...f1ed8d6 |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Apr 9, 2026
PR-URL: #62397 Refs: nodejs/diagnostics#654 Refs: https://issues.chromium.org/issues/457135433 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
nodejs-github-bot
pushed a commit
that referenced
this pull request
Apr 9, 2026
PR-URL: #62397 Refs: nodejs/diagnostics#654 Refs: https://issues.chromium.org/issues/457135433 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
nodejs-github-bot
pushed a commit
that referenced
this pull request
Apr 9, 2026
PR-URL: #62397 Refs: nodejs/diagnostics#654 Refs: https://issues.chromium.org/issues/457135433 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds Perfetto SDK as a dependency of Node.js. Notably, this does not add the full Perfetto library as the dependency. The full perfetto library contains Perfetto data pipeline processing support. The Perfetto SDK only supports emitting tracing data.
This is part of the nodejs/diagnostics#654 discussion that V8 moves away from the legacy tracing library.
Key points:
This PR only adds the Perfetto SDK. The actual adoption is blocked on #61898 with patches in https://issues.chromium.org/issues/457135433.
Commit efdce9a can be fully reproduced with
tools/dep_updaters/update-perfetto.sh.Refs: nodejs/diagnostics#654
Refs: https://issues.chromium.org/issues/457135433