buffer: add end parameter

[ronag]

To limit how far into the buffer we search without allocating an unnecessary subarray.

[mcollina]

lgtm

[mcollina]

CI does not seem happy

[codecov]

Codecov Report

❌ Patch coverage is 86.13861% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.78%. Comparing base (bf1aebc) to head (999b453).
⚠️ Report is 47 commits behind head on main.

Files with missing lines	Patch %	Lines
src/node_buffer.cc	70.83%	4 Missing and 10 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #62390      +/-   ##
==========================================
+ Coverage   89.72%   89.78%   +0.06%     
==========================================
  Files         695      699       +4     
  Lines      214464   216282    +1818     
  Branches    41067    41349     +282     
==========================================
+ Hits       192420   194193    +1773     
- Misses      14106    14188      +82     
+ Partials     7938     7901      -37     

Files with missing lines	Coverage Δ
lib/buffer.js	99.18% <100.00%> (+0.01%)	⬆️
src/node_buffer.cc	68.03% <70.83%> (-0.17%)	⬇️

... and 84 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[jasnell]

When we start getting into new optional arguments in the middle like this I think we should consider an alternative signature with an options bag instead...

buf.includes(value, {
  byteOffset: 0,
  end: 10,
  encoding: 'utf8',
});

[ronag]

follow up PR?

[github-actions]

Failed to start CI

   ⚠  Commits were pushed since the last approving review:
   ⚠  - buffer: add end parameter
   ✘  Refusing to run CI on potentially unsafe PR

https://github.com/nodejs/node/actions/runs/23542726197

[aduh95]

There's a conflict to solve

[mcollina]

lgtm

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/72535/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/72552/

[nodejs-github-bot]

Commit Queue failed

- Loading data for nodejs/node/pull/62390
✔  Done loading data for nodejs/node/pull/62390
----------------------------------- PR info ------------------------------------
Title      buffer: add end parameter (#62390)
Author     Robert Nagy <ronagy@icloud.com> (@ronag)
Branch     ronag:buffer-index-of-end -> nodejs:main
Labels     buffer, c++, semver-minor, author ready, needs-ci, review wanted
Commits    1
 - buffer: add end parameter
Committers 1
 - Robert Nagy <ronagy@icloud.com>
PR-URL: https://github.com/nodejs/node/pull/62390
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/62390
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sun, 22 Mar 2026 09:53:58 GMT
   ✔  Approvals: 1
   ✔  - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/62390#pullrequestreview-4067847074
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2026-04-08T05:43:34Z: https://ci.nodejs.org/job/node-test-pull-request/72552/
- Querying data for job/node-test-pull-request/72552/
✔  Build data downloaded
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 62390
From https://github.com/nodejs/node
 * branch                  refs/pull/62390/merge -> FETCH_HEAD
✔  Fetched commits as 70c1d6b7314f..445df3f2a63a
--------------------------------------------------------------------------------
[main c26888b5a4] buffer: add end parameter
 Author: Robert Nagy <ronagy@icloud.com>
 Date: Sun Mar 22 10:53:00 2026 +0100
 5 files changed, 195 insertions(+), 58 deletions(-)
   ✔  Patches applied
--------------------------------------------------------------------------------
   ⚠  Found PR-URL: https://github.com/nodejs/node/pull/62390, skipping..
--------------------------------- New Message ----------------------------------
buffer: add end parameter
To limit how far into the buffer we search without allocating an

unnecessary subarray.
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
[main 3fb6848c29] buffer: add end parameter

Author: Robert Nagy <ronagy@icloud.com>

Date: Sun Mar 22 10:53:00 2026 +0100

5 files changed, 195 insertions(+), 58 deletions(-)

✖  3fb6848c294c6f3d05c60720e0fbe3ac0cf11cd1

✔  0:0      no Co-authored-by metadata                co-authored-by-is-trailer

✔  0:0      skipping fixes-url                        fixes-url

✔  0:0      blank line after title                    line-after-title

✔  0:0      line-lengths are valid                    line-length

✔  0:0      metadata is at end of message             metadata-end

✖  0:0      Commit must have a PR-URL.                pr-url

✔  0:0      reviewers are valid                       reviewers

✔  0:0      valid subsystems                          subsystem

✔  0:0      Title is formatted correctly.             title-format

✔  0:0      Title is <= 50 columns.                   title-length
ℹ  Please fix the commit message and try again.

Please manually ammend the commit message, by running

git commit --amend

Once commit message is fixed, finish the landing command running

git node land --continue

https://github.com/nodejs/node/actions/runs/24207909791