fix(web): add noopener and noreferrer to external source links#771
Open
Sahilshrma31 wants to merge 1 commit intonodejs:mainfrom
Open
fix(web): add noopener and noreferrer to external source links#771Sahilshrma31 wants to merge 1 commit intonodejs:mainfrom
Sahilshrma31 wants to merge 1 commit intonodejs:mainfrom
Conversation
PR SummaryLow Risk Overview Reviewed by Cursor Bugbot for commit 15b232b. Bugbot is set up for automated code reviews on this repo. Configure here. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
araujogui
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds rel="noopener noreferrer" to source-code links generated by the web docs pipeline when links open in a new tab (target="_blank").
The source link rendering in jsx-ast currently opens external GitHub links in a new tab but does not set a rel attribute. This change hardens link behavior by preventing opener access and aligning with standard security best practices for external links.
Validation
I validated this by generating docs and inspecting rendered source-code links in the output HTML.
Before
Generated source links had:
target="_blank"
no rel attribute
After
Generated source links now have:
target="_blank"
rel="noopener noreferrer"
This preserves existing behavior (open in new tab) while adding safer link semantics.
Related Issues
N/A
Check List
node --run testand all tests passed.node --run format&node --run lint.