ansible: fix existing Java detection edge case#4295
Open
richardlau wants to merge 1 commit intonodejs:mainfrom
Open
ansible: fix existing Java detection edge case#4295richardlau wants to merge 1 commit intonodejs:mainfrom
richardlau wants to merge 1 commit intonodejs:mainfrom
Conversation
Add additional check for whether an existing `java` ran successfully as the original check could erroneously match if the Java version being checked for was in an error message (e.g. part of the directory name included in the message).
sxa
approved these changes
Apr 9, 2026
Member
sxa
left a comment
There was a problem hiding this comment.
I'm guessing this has been tested, in which case I approve.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add additional check for whether an existing
javaran successfully as the original check could erroneously match if the Java version being checked for was in an error message (e.g. part of the directory name included in the message).An example (from playbook runs for #4294):
The original check was passing because
jdk-17.0.18+8was in stdout from the failing command.