Skip to content

fix: handle cancellation race in RequestResponder.respond() #2417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lui62233 wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −1
Open

fix: handle cancellation race in RequestResponder.respond() #2417

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/mcp/shared/session.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,9 @@ async def respond(self, response: SendResultT | ErrorData) -> None:
"""
if not self._entered: # pragma: no cover
raise RuntimeError("RequestResponder must be used as a context manager")
assert not self._completed, "Request already responded to"
# Guard against race: if cancel() already set _completed, skip silently.
if self._completed:
return

if not self.cancelled: # pragma: no branch
self._completed = True
Expand Down