feat: add resource seeding to mcpserver#2414
Open
mplemay wants to merge 2 commits intomodelcontextprotocol:mainfrom
Open
feat: add resource seeding to mcpserver#2414mplemay wants to merge 2 commits intomodelcontextprotocol:mainfrom
mplemay wants to merge 2 commits intomodelcontextprotocol:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add constructor-time resource seeding to
ResourceManagerand wireMCPServerthrough it so servers can preload concrete resources at initialization, matching the existing tool manager pattern.Motivation and Context
This makes resource registration consistent with tool registration and removes the manual loop from
MCPServer.__init__. It also makes it easier to create pre-populated servers without adding extra setup code after construction.How Has This Been Tested?
uv run --frozen pytest tests/server/mcpserver/resources/test_resource_manager.pyuv run --frozen pytest tests/server/mcpserver/test_server.py -k init_with_resourcesuv run --frozen ruff check src/mcp/server/mcpserver/resources/resource_manager.py src/mcp/server/mcpserver/server.py tests/server/mcpserver/resources/test_resource_manager.py tests/server/mcpserver/test_server.pyBreaking Changes
None.
ResourceManager(resources=...)andMCPServer(resources=...)are additive.Types of changes
Checklist
Additional context
Resource seeding now happens inside
ResourceManager.__init__, soMCPServerno longer needs a manual registration loop. Duplicate resources continue to flow throughadd_resource(...), preserving first-write-wins behavior and existing duplicate warnings.