-
Notifications
You must be signed in to change notification settings - Fork 864
fix: Remove JsonSchema and use a Map for inputSchema to support json schemas dialect #749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Kehrlann
merged 9 commits into
modelcontextprotocol:main
from
bilaloumehdi:fix/json-schema-spec-support
Apr 10, 2026
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
6b0a8ee
feat: remove JsonSchema an use a Map for inputSchema
bilaloumehdi 26ecf80
test: add test for a schema contains oneof
bilaloumehdi 1fdc258
Merge branch 'main' into fix/json-schema-spec-support
bilaloumehdi c2f459e
chore: Merge branch 'main' into fix/json-schema-spec-support
bilaloumehdi fc76143
test: fix conformance-tests
bilaloumehdi 0180bb5
Merge branch 'main' into fix/json-schema-spec-support
bilaloumehdi 5229550
Merge branch 'main' into fix/json-schema-spec-support
bilaloumehdi 52b5642
polish gh-749
Kehrlann e5f3581
Merge branch 'main' into fix/json-schema-spec-support
Kehrlann File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 changes: 3 additions & 4 deletions
7
mcp-core/src/test/java/io/modelcontextprotocol/util/ToolsUtils.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,15 +1,14 @@ | ||
| package io.modelcontextprotocol.util; | ||
|
|
||
| import io.modelcontextprotocol.spec.McpSchema; | ||
|
|
||
| import java.util.Collections; | ||
| import java.util.Map; | ||
|
|
||
| public final class ToolsUtils { | ||
|
|
||
| private ToolsUtils() { | ||
| } | ||
|
|
||
| public static final McpSchema.JsonSchema EMPTY_JSON_SCHEMA = new McpSchema.JsonSchema("object", | ||
| Collections.emptyMap(), null, null, null, null); | ||
| public static final Map<String, Object> EMPTY_JSON_SCHEMA = Map.of("type", "object", "properties", | ||
| Collections.emptyMap()); | ||
|
|
||
Kehrlann marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 changes: 3 additions & 4 deletions
7
mcp-test/src/main/java/io/modelcontextprotocol/util/ToolsUtils.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,15 +1,14 @@ | ||
| package io.modelcontextprotocol.util; | ||
|
|
||
| import io.modelcontextprotocol.spec.McpSchema; | ||
|
|
||
| import java.util.Collections; | ||
| import java.util.Map; | ||
|
|
||
| public final class ToolsUtils { | ||
|
|
||
| private ToolsUtils() { | ||
| } | ||
|
|
||
| public static final McpSchema.JsonSchema EMPTY_JSON_SCHEMA = new McpSchema.JsonSchema("object", | ||
Kehrlann marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| Collections.emptyMap(), null, null, null, null); | ||
| public static final Map<String, Object> EMPTY_JSON_SCHEMA = Map.of("type", "object", "properties", | ||
| Collections.emptyMap()); | ||
|
|
||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.