Skip to content

10 create end to end trade management logic #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mccaffers wants to merge 11 commits into
base: main
Choose a base branch
from

Updating github workflow os

27f82f1
Select commit
Loading
Failed to load commit list.
Open

10 create end to end trade management logic #14

Updating github workflow os
27f82f1
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Apr 12, 2026 in 27s

Quality Gate failed

Failed conditions
13.5% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Annotations

Check warning on line 18 in source/databaseConnection.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use the init-statement to declare "parsedFields" inside the if statement. 

See more on https://sonarcloud.io/project/issues?id=mccaffers_backtesting-engine-cpp&issues=AZ2DLQYyO-njQfcvJl3-&open=AZ2DLQYyO-njQfcvJl3-&pullRequest=14

Check warning on line 50 in source/operations.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the commented out code. 

See more on https://sonarcloud.io/project/issues?id=mccaffers_backtesting-engine-cpp&issues=AZ2DLQazO-njQfcvJl4I&open=AZ2DLQazO-njQfcvJl4I&pullRequest=14

Check warning on line 15 in source/databaseConnection.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define each identifier in a dedicated statement. 

See more on https://sonarcloud.io/project/issues?id=mccaffers_backtesting-engine-cpp&issues=AZ2DLQYyO-njQfcvJl3_&open=AZ2DLQYyO-njQfcvJl3_&pullRequest=14

Check warning on line 61 in source/databaseConnection.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define each identifier in a dedicated statement. 

See more on https://sonarcloud.io/project/issues?id=mccaffers_backtesting-engine-cpp&issues=AZ2DLQYyO-njQfcvJl4C&open=AZ2DLQYyO-njQfcvJl4C&pullRequest=14

Check warning on line 60 in source/databaseConnection.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

implicit conversion loses integer precision: 'std::size_t' (aka 'unsigned long') to 'size_type' (aka 'int') 

See more on https://sonarcloud.io/project/issues?id=mccaffers_backtesting-engine-cpp&issues=AZ2DLQYyO-njQfcvJl39&open=AZ2DLQYyO-njQfcvJl39&pullRequest=14

Check warning on line 47 in source/operations.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the commented out code. 

See more on https://sonarcloud.io/project/issues?id=mccaffers_backtesting-engine-cpp&issues=AZ2DLQazO-njQfcvJl4H&open=AZ2DLQazO-njQfcvJl4H&pullRequest=14

Check warning on line 38 in source/operations.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this use of "strftime" with equivalent code using "std::chrono". 

See more on https://sonarcloud.io/project/issues?id=mccaffers_backtesting-engine-cpp&issues=AZ2DLQazO-njQfcvJl4E&open=AZ2DLQazO-njQfcvJl4E&pullRequest=14

Check warning on line 21 in source/sqlManager.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use std::format instead of concatenating pieces manually. 

See more on https://sonarcloud.io/project/issues?id=mccaffers_backtesting-engine-cpp&issues=AZ2DLQbIO-njQfcvJl4K&open=AZ2DLQbIO-njQfcvJl4K&pullRequest=14

Check warning on line 23 in source/databaseConnection.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use "std::string" instead of a C-style char array. 

See more on https://sonarcloud.io/project/issues?id=mccaffers_backtesting-engine-cpp&issues=AZ2DLQYyO-njQfcvJl4B&open=AZ2DLQYyO-njQfcvJl4B&pullRequest=14

Check warning on line 37 in source/operations.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use "std::string" instead of a C-style char array. 

See more on https://sonarcloud.io/project/issues?id=mccaffers_backtesting-engine-cpp&issues=AZ2DLQazO-njQfcvJl4F&open=AZ2DLQazO-njQfcvJl4F&pullRequest=14

Check warning on line 44 in source/operations.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

unused variable 'tradeManager' 

See more on https://sonarcloud.io/project/issues?id=mccaffers_backtesting-engine-cpp&issues=AZ2DLQazO-njQfcvJl4D&open=AZ2DLQazO-njQfcvJl4D&pullRequest=14

Check warning on line 53 in source/operations.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the commented out code. 

See more on https://sonarcloud.io/project/issues?id=mccaffers_backtesting-engine-cpp&issues=AZ2DLQazO-njQfcvJl4J&open=AZ2DLQazO-njQfcvJl4J&pullRequest=14

Check warning on line 19 in source/databaseConnection.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define and throw a dedicated exception instead of using a generic one. 

See more on https://sonarcloud.io/project/issues?id=mccaffers_backtesting-engine-cpp&issues=AZ2DLQYyO-njQfcvJl4A&open=AZ2DLQYyO-njQfcvJl4A&pullRequest=14

Check warning on line 44 in source/operations.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Value stored to 'tradeManager' during its initialization is never read 

See more on https://sonarcloud.io/project/issues?id=mccaffers_backtesting-engine-cpp&issues=AZ2DLQazO-njQfcvJl4G&open=AZ2DLQazO-njQfcvJl4G&pullRequest=14
View more details on SonarQubeCloud