Open
Conversation
rcosta358
added
enhancement
Collaborator
CatarinaGamboa
left a comment
CatarinaGamboa
left a comment
There was a problem hiding this comment.
I think I need some description of our approach on this. So we check satisfiability every time that we try to get the value of a @Refinement (and skip if it already has it). But why do we need to add the vars to context? what if a refinements mentions several params that are not yet in context?
| return constr; | ||
| } | ||
|
|
||
| private void checkRefinementSatisfiability(String refinement, Predicate predicate, CtElement element) { |
| CtTypeReference<?> annotationType = element instanceof CtTypedElement<?> typedElement | ||
| ? typedElement.getType() : null; | ||
| if (annotationType != null && !context.hasVariable(Keys.WILDCARD)) | ||
| context.addVarToContext(Keys.WILDCARD, annotationType, p, element); |
Collaborator
There was a problem hiding this comment.
I'm a bit confused, why are we adding the vars to context here? because this happens before we add them to context?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a warning for unsatisfiable, self-contradictory refinements. It also avoids re-running the same satisfiability check for the same element across verifier passes.
Examples