Open
Conversation
CatarinaGamboa
approved these changes
Apr 10, 2026
Collaborator
CatarinaGamboa
left a comment
CatarinaGamboa
left a comment
There was a problem hiding this comment.
lgtm, check the minor comments i left
| } else if (left instanceof Var leftVar && right instanceof Var rightVar) { | ||
| // to substitute internal variable with user-facing variable | ||
| if (leftVar.isInternal() && !rightVar.isInternal()) { | ||
| if (isInternal(leftVar) && !isInternal(rightVar) && !isReturnVar(leftVar)) { |
Collaborator
There was a problem hiding this comment.
could we have like a isKeywordVar or isSpecialVar to cover both Fresh and Ret?
| } | ||
|
|
||
| private static boolean isFreshVar(Var var) { | ||
| return var.getName().startsWith("#fresh_"); |
Collaborator
There was a problem hiding this comment.
could these be dependent on the final strings where we define the format for fresh and ret instead of hard coded?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the substitution of special variables so
#ret_nis never replaced by another variable and#fresh_nis never used as the replacement for some other variable.Example
Before
After