verify: adds timeout to requests.get() calls#145
Open
timfeierabend wants to merge 1 commit intolinuxmint:masterfrom
Open
verify: adds timeout to requests.get() calls#145timfeierabend wants to merge 1 commit intolinuxmint:masterfrom
timfeierabend wants to merge 1 commit intolinuxmint:masterfrom
Conversation
by default, requests.get() has an indefinite timeout. if there is a upstream network disruption preventing access to the resource, the verify dialog becomes unresponsive when trying to verify an ISO.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default,
requests.get()has an indefinite timeout. If there is a upstream network disruption preventing access to the resource, the verify dialog becomes unresponsive when trying to verify an ISO because it waits forever to download the signatures and hashes.In dual stack internet connections, the timeout is needed to retry with the ipv4 connection if there is a disruption on the initial ipv6 connection.