Implement native size/time log rotation with gzip compression#189
Open
Anyitechs wants to merge 1 commit intolightningdevkit:mainfrom
Open
Implement native size/time log rotation with gzip compression#189Anyitechs wants to merge 1 commit intolightningdevkit:mainfrom
Anyitechs wants to merge 1 commit intolightningdevkit:mainfrom
Conversation
|
🎉 This PR is now ready for review! |
Collaborator
|
I would rather keep the old version. I like all the handling for the different signals in |
Update the ServerLogger to track file size and age internally, triggering rotation at 50MB or 24 hours. Old logs are now compressed in the background using native OS gzip via `std::thread::spawn`, eliminating the need for the user to configure `logrotate`. Disk writes are also now buffered for better runtime performance. Co-Authored-By: Gemini 3.0 Pro
Anyitechs
changed the title
Contributor
Author
As we discussed elsewhere, this is now dropped entirely as we're moving to doing the rotation ourselves rather than relying on the user to configure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the
ServerLoggerto track file size and age internally, triggering rotation at 50MB or 24 hours. Old logs are now compressed in the background using native OSgzipviastd::thread::spawn, eliminating the need for the user to configurelogrotate.Disk writes are also now buffered for better runtime performance.