Skip to content

fix(tasks): warn when due time is ignored by API#700

Open
jeevan6996 wants to merge 3 commits intogoogleworkspace:mainfrom
jeevan6996:fix/696-tasks-due-time-warning
Open

fix(tasks): warn when due time is ignored by API#700
jeevan6996 wants to merge 3 commits intogoogleworkspace:mainfrom
jeevan6996:fix/696-tasks-due-time-warning

Conversation

@jeevan6996
Copy link
Copy Markdown

Summary

  • add a targeted warning when requests to Google Tasks include a non-midnight due timestamp, since the Tasks API stores only date information and discards time-of-day
  • scope the warning to Tasks write operations (POST/PUT/PATCH) so other APIs are unaffected
  • add unit tests for non-midnight detection, midnight-no-warning behavior, and non-Tasks API behavior
  • include a patch changeset

Fixes #696

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 11, 2026

🦋 Changeset detected

Latest commit: 1271b41

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@googleworkspace/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a proactive warning system for the Google Tasks CLI integration. By detecting when users provide a due date with a non-midnight time component, the CLI can now inform the user that this time information will be discarded by the Google Tasks API, thereby improving transparency and preventing potential confusion regarding task scheduling.

Highlights

  • Warning Implementation: Added a warning mechanism to alert users when a Google Tasks API request includes a non-midnight due timestamp, as the API ignores time-of-day information.
  • Scope Limitation: Ensured the warning is only triggered for Tasks write operations (POST, PUT, PATCH) to prevent false positives in other API calls.
  • Testing: Added comprehensive unit tests to verify the detection logic, ensuring midnight timestamps and non-Tasks APIs do not trigger the warning.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Generative AI Prohibited Use Policy, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a warning for Google Tasks API requests that include a non-midnight due time, as the API only stores the date and ignores the time-of-day. The changes include a new utility to parse the due field and logic within the executor to print a warning to stderr during POST, PUT, or PATCH operations. A security concern was raised regarding the potential for terminal escape sequence injection because the warning message includes user-controlled input; a suggestion was provided to sanitize the output before printing.

Comment thread crates/google-workspace-cli/src/executor.rs Outdated
@jeevan6996
Copy link
Copy Markdown
Author

Addressed the review concern about terminal safety: warning output now sanitizes the due timestamp before printing to stderr (sanitize_for_terminal). Pushed in 83df826.

@googleworkspace-bot
Copy link
Copy Markdown
Collaborator

/gemini review

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a warning mechanism for Google Tasks API requests when a non-midnight due time is provided, as the API ignores time-of-day. The changes include logic to parse the due field and a new warning message printed to the terminal. A review comment points out that the current parsing logic fails to detect non-midnight times involving fractional seconds and suggests a more robust implementation.

Comment thread crates/google-workspace-cli/src/executor.rs
@jeevan6996
Copy link
Copy Markdown
Author

Addressed the new review point as well: extract_due_string_with_non_midnight_time now detects non-midnight fractional seconds (e.g. 00:00:00.500Z) by scanning the time segment for any non-zero digit, and includes a regression test for this case. Pushed in 1271b41.

@googleworkspace-bot
Copy link
Copy Markdown
Collaborator

/gemini review

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a warning for Google Tasks API requests that include a non-midnight due time, as the API only stores the date and ignores the time-of-day. The implementation includes logic to parse the due field from the request body and check for non-zero time components, along with corresponding unit tests to verify the behavior across different scenarios. I have no feedback to provide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug - Tasks - set due time

2 participants