refactor(build): centralize secrets enforcement and modernize CI bypass#37
Open
dkhawk wants to merge 5 commits intogooglemaps-samples:mainfrom
Open
refactor(build): centralize secrets enforcement and modernize CI bypass#37dkhawk wants to merge 5 commits intogooglemaps-samples:mainfrom
dkhawk wants to merge 5 commits intogooglemaps-samples:mainfrom
Conversation
Centralize the secrets.properties enforcement logic into a single authoritative check in the root build.gradle.kts file, removing heavy duplication across six subprojects. Replace brittle runtime environment checks with safe, build-time BuildConfig.IS_CI constants for automated testing pipelines. - Create root build.gradle.kts for workspace-wide validation - Remove duplicated secrets-checking blocks from subproject scripts - Inject BuildConfig.IS_CI and apply manifest placeholders in CI - Update Application classes to respect BuildConfig.IS_CI early returns - Untrack LOG.md and add to local exclude file - Fill out missing PLACES_API_KEY in defaults properties
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Centralize the secrets.properties enforcement logic into a single authoritative check in the root build.gradle.kts file, removing duplication across subprojects. Replace brittle runtime checks with safe build-time constants for automated testing.