fix: Make LlmResponse constructor protected for external subclassing#1137
Open
jinnigu wants to merge 1 commit intogoogle:mainfrom
Open
fix: Make LlmResponse constructor protected for external subclassing#1137jinnigu wants to merge 1 commit intogoogle:mainfrom
jinnigu wants to merge 1 commit intogoogle:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please ensure you have read the contribution guide before creating a pull request.
Link to Issue or Description of Change
1. Link to an existing issue (if applicable):
Problem:
The
LlmResponseconstructor uses package-private (default) visibility, which prevents users from subclassingLlmResponseoutside of thecom.google.adk.modelspackage. This blocks custom LLM integrations (e.g., connecting LM Studio or other local models) that need to extendLlmResponse.Solution:
Change the
LlmResponseconstructor from package-private toprotected. This is the minimal change needed. It allows subclassing from external packages while still preventing arbitrary instantiation (unlikepublic). The@AutoValue-generated subclass in the same package is unaffected.Testing Plan
Unit Tests:
Added
ExternalLlmResponseSubclassTestin thecom.google.adk.models.externalpackage (outsidecom.google.adk.models) to verify that an external subclass ofLlmResponsecan be instantiated.Checklist