Open
Conversation
cruessler
requested changes
Apr 9, 2026
Collaborator
cruessler
left a comment
cruessler
left a comment
There was a problem hiding this comment.
Looks good to me! I tested on my Ubuntu machine using cargo run. Just one quick question.
WaterWhisperer
force-pushed
the
open-editor-in-diff-view
branch
from
05612e0 to
a2dc9ab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request fixes/closes #2805.
It changes the following:
DiffComponentnow displays theEdit [e]command in mutable diff scenarios and reuses the existingInternalEvent::OpenExternalEditor(Some(path))flow wheneis pressed.I followed the checklist:
make checkwithout errors