Skip to content

C++: Remove deprecated code deprecated more than a year ago#21709

Merged
jketema merged 2 commits intogithub:mainfrom
jketema:depr
Apr 14, 2026
Merged

C++: Remove deprecated code deprecated more than a year ago#21709
jketema merged 2 commits intogithub:mainfrom
jketema:depr

Conversation

@jketema
Copy link
Copy Markdown
Contributor

@jketema jketema commented Apr 14, 2026

Not need to run DCA on this; just piggy backing some DCA on this PR to test something.

@github-actions github-actions bot added the C++ label Apr 14, 2026
@jketema jketema changed the title C++: Remove deprecated code added more than a year ago C++: Remove deprecated code deprecated more than a year ago Apr 14, 2026
@jketema jketema marked this pull request as ready for review April 14, 2026 11:50
@jketema jketema requested a review from a team as a code owner April 14, 2026 11:50
Copilot AI review requested due to automatic review settings April 14, 2026 11:50
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes long-deprecated C++ CodeQL modeling interfaces (ThrowingFunction and NonThrowingFunction) and adds a breaking change note documenting the migration paths.

Changes:

  • Removed deprecated ThrowingFunction interface from Throwing.qll.
  • Removed deprecated NonThrowingFunction alias from NonThrowing.qll.
  • Added a breaking change note describing the removals and replacements.
Show a summary per file
File Description
cpp/ql/lib/semmle/code/cpp/models/interfaces/Throwing.qll Removes deprecated ThrowingFunction API.
cpp/ql/lib/semmle/code/cpp/models/interfaces/NonThrowing.qll Removes deprecated NonThrowingFunction alias.
cpp/ql/lib/change-notes/2026-04-14-throwing.md Documents the breaking removals and migration targets.

Copilot's findings

Comments suppressed due to low confidence (1)

cpp/ql/lib/semmle/code/cpp/models/interfaces/Throwing.qll:16

  • The module-level documentation at the top of this file still instructs users to extend ThrowingFunction, but ThrowingFunction is removed in this PR. Please update the header comment to reference the current API (likely AlwaysSehThrowingFunction) and adjust the description accordingly so it no longer claims to model generic “may throw” behavior if the module now only exposes SEH-throwing behavior.
/**
 * A function that unconditionally raises a structured exception handling (SEH) exception.
 */
abstract class AlwaysSehThrowingFunction extends Function { }
  • Files reviewed: 3/3 changed files
  • Comments generated: 0

Copy link
Copy Markdown
Contributor

@tausbn tausbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@jketema jketema merged commit ae22263 into github:main Apr 14, 2026
24 checks passed
@jketema jketema deleted the depr branch April 14, 2026 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants