Update README updating deepClone function to include case where arrays inside objects were being converted to plain objects during cloning#122
Open
div360 wants to merge 1 commit intoganqqwerty:masterfrom
Conversation
…ts were being converted to plain objects during cloning
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Problem
When object[key] is an array, typeof object[key] returns 'object' — so it goes into the recursive branch and calls deepClone(array).
Inside deepClone, a fresh {} (plain object) is created, and then for...in loops over the array's numeric indices as keys.
Added a fix to check if it's an array before creating the clone container:
var newObject = Array.isArray(object) ? [] : {};Without
Array.isArray()check,[1, 2, 3]was silently cloned as{ "0": 1, "1": 2, "2": 3 }since both arrays and objects return"object"fortypeof,fixed by initializingnewObjectas[]when the input is an array