Disable programmatic scrolling for anchored entries#2672
Open
spamguy wants to merge 1 commit intofreeCodeCamp:mainfrom
Open
Disable programmatic scrolling for anchored entries#2672spamguy wants to merge 1 commit intofreeCodeCamp:mainfrom
spamguy wants to merge 1 commit intofreeCodeCamp:mainfrom
Conversation
… they are never cached.
spamguy
changed the title
|
Please merge soon. Bug is definitely a major one. |
|
I second Neonit's request. This bug makes devdocs basically useless the way I work. |
|
Does anyone know how to deploy this PR? Please :-) |
|
A workaround for me (using desktop Firefox) is re-submitting the URL (does not reload the page), if a click on an entry in the left column doesn't beam me to the anchor. Shortcut: CTRL + L, ENTER. (F5 also does the job, but it reloads the page and takes a lot longer) |
Contributor
Author
AFAIK @simon04 is the primary admin that can approve, merge, and deploy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a breakage caused by PR #2667 in which all route visits with no cached scroll position reset to the top. Anchored entries rely on the href's anchor to set scroll position and don't use cache; thus, all anchored entries scroll to the top.
nim's HTML cleaner was also updated to remove 'Source'/'Edit' links.
Fixes #2671 .