Add KDE KWallet D-Bus permissions for credential storage#661
Open
AnttiJalomaki wants to merge 1 commit intoflathub:masterfrom
Open
Add KDE KWallet D-Bus permissions for credential storage#661AnttiJalomaki wants to merge 1 commit intoflathub:masterfrom
AnttiJalomaki wants to merge 1 commit intoflathub:masterfrom
Conversation
VS Code detects KDE and attempts to use KWallet for secure credential storage, but the Flatpak sandbox blocks D-Bus access to the KWallet service. This causes "OS keyring is not available for encryption" errors and credentials (e.g. GitHub login) not persisting across restarts. Add talk-name permissions for both kwalletd5 (KDE 5) and kwalletd6 (KDE 6). The org.freedesktop.secrets permission already present is not sufficient on KDE desktops. Fixes flathub#422
Contributor
|
🚧 Test build enqueued. |
Contributor
|
🚧 Started test build. |
Contributor
|
✅ Test build succeeded. To test this build, install it from the testing repository: Built for aarch64 and x86_64 architectures. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--talk-name=org.kde.kwalletd5and--talk-name=org.kde.kwalletd6tofinish-argsContext
VS Code detects KDE and attempts to use KWallet for credential storage, but the Flatpak sandbox blocks D-Bus access to the KWallet service. KDE 5 uses
org.kde.kwalletd5, KDE 6 usesorg.kde.kwalletd6— both are added for compatibility.The VSCodium Flatpak (
com.vscodium.codium) already includeskwalletd5in its manifest. Theorg.freedesktop.secretstalk-name already present is not sufficient on KDE desktops.Tested on: Fedora 43, KDE Plasma 6.x — confirmed that adding the
kwalletd6talk-name viaflatpak override --userresolves the issue.Fixes #422