fix: place text field caret at end of preloaded text#51
Open
mikenye wants to merge 3 commits intoebitengine:mainfrom
Open
fix: place text field caret at end of preloaded text#51mikenye wants to merge 3 commits intoebitengine:mainfrom
mikenye wants to merge 3 commits intoebitengine:mainfrom
Conversation
…on' into fix-textfield-caret-start-position # Conflicts: # textfield.go # textfield_test.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a
TextFieldbug where typing into a field with an existing value could insert new characters at the start of the string instead of at the end. Fixes #50.Problem
debuguicachestextinput.Fieldinstances per widget ID. When aTextFieldwas reopened or reused with preloaded text, the cached field could keep an old selection/insertion point from a previous editing session.That meant the visible text was correct, but the next typed character could still be inserted at byte 0.
A related issue existed in
SetTextFieldValue, which updated the field text but reset the selection to 0,0, leaving the next insertion at the start of the string.Fix
This change:
SetTextFieldValueto place the selection at the end of the new valueTests
Adds regression tests covering:
SetTextFieldValuemoving the caret to the end of the new text