engine/logging: fix json-file compress default value#24815
Open
lacatoire wants to merge 2 commits intodocker:mainfrom
Open
engine/logging: fix json-file compress default value#24815lacatoire wants to merge 2 commits intodocker:mainfrom
lacatoire wants to merge 2 commits intodocker:mainfrom
Conversation
The option is parsed as a boolean by strconv.ParseBool, so 'disabled' wasn't a valid value and misled readers. Align the default with the in-file convention used by max-size and max-file. Closes docker#21898
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
compressoption is parsed as a boolean viastrconv.ParseBoolinmoby/moby daemon/logger/jsonfilelog/jsonfilelog.go. The previous wording claimed the default wasdisabled, which isn't a value the parser accepts (users copy-pasting it would hit an error). Aligns with the in-file convention already used bymax-sizeandmax-file.Closes #21898