Skip to content

Fix #14664 FN constStatement for array of pointers to struct #8439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chrchr-github merged 2 commits into from
Apr 11, 2026
+10 −1
Merged

Fix #14664 FN constStatement for array of pointers to struct #8439

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e0b61fb
Update astutils.cpp
chrchr-github Apr 10, 2026
1b83565
Update testincompletestatement.cpp
chrchr-github Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/astutils.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2120,7 +2120,8 @@ bool isWithoutSideEffects(const Token* tok, bool checkArrayAccess, bool checkRef
tok = tok->astOperand2();
if (tok && tok->varId()) {
const Variable* var = tok->variable();
return var && ((!var->isClass() && (checkReference || !var->isReference())) || var->isPointer() || (checkArrayAccess ? var->isStlType() && !var->isStlType(CheckClass::stl_containers_not_const) : var->isStlType()));
return var && ((!var->isClass() && (checkReference || !var->isReference())) || var->isPointer() ||
(checkArrayAccess ? var->isArray() || (var->isStlType() && !var->isStlType(CheckClass::stl_containers_not_const)) : var->isStlType()));
}
return true;
}
Expand Down
8 changes: 8 additions & 0 deletions test/testincompletestatement.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -750,6 +750,14 @@ class TestIncompleteStatement : public TestFixture {
" g<sizeof(wchar_t)>();\n"
"}\n");
ASSERT_EQUALS("", errout_str());

check("struct S;\n" // #14664
"S* a[1];\n"
"void f() {\n"
" a[0];\n"
"}\n");
ASSERT_EQUALS("[test.cpp:4:6]: (warning) Redundant code: Found unused array access. [constStatement]\n",
errout_str());
}

void vardecl() {
Expand Down
Loading