Skip to content

Inline budget now has a symmetric ramp down#235

Open
mvandeberg wants to merge 1 commit intocppalliance:developfrom
mvandeberg:pr/symmetric-ramp
Open

Inline budget now has a symmetric ramp down#235
mvandeberg wants to merge 1 commit intocppalliance:developfrom
mvandeberg:pr/symmetric-ramp

Conversation

@mvandeberg
Copy link
Copy Markdown
Contributor

@mvandeberg mvandeberg commented Apr 17, 2026

Summary by CodeRabbit

  • Bug Fixes
    • Improved the adaptive inline-budget scaling behavior in the reactor scheduler to reduce budget more gradually instead of completely resetting. This ensures better system stability and responsiveness during high-load conditions while preventing excessive performance drops.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 17, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 4e433211-1e22-4c5b-b386-ea64fdd8cdb0

📥 Commits

Reviewing files that changed from the base of the PR and between 18a8a2f and f91a2b7.

📒 Files selected for processing (1)
  • include/boost/corosio/native/detail/reactor/reactor_scheduler.hpp

📝 Walkthrough

Walkthrough

The reactor_scheduler::reset_inline_budget() function has been modified to apply a gradual reduction strategy to the inline budget maximum. Instead of resetting directly to the initial value, it now reduces the maximum by half while ensuring it never drops below the initial threshold.

Changes

Cohort / File(s) Summary
Inline Budget Reduction Logic
include/boost/corosio/native/detail/reactor/reactor_scheduler.hpp
Modified reset_inline_budget() to reduce inline_budget_max to max(ctx->inline_budget_max / 2, inline_budget_initial_) instead of unconditionally resetting to inline_budget_initial_, enabling adaptive budget decay while maintaining a floor at the initial value.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A rabbit whispers, "Half and half again!
No budget drops below where it began,
With careful math and gentle care,
We dance through reactors light as air!" 📉✨

🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Inline budget now has a symmetric ramp down' accurately describes the main change: the reset_inline_budget() function now uses a symmetric halving approach instead of unconditional reset.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@cppalliance-bot
Copy link
Copy Markdown

An automated preview of the documentation is available at https://235.corosio.prtest3.cppalliance.org/index.html

If more commits are pushed to the pull request, the docs will rebuild at the same URL.

2026-04-17 20:17:27 UTC

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.71%. Comparing base (3fc8c97) to head (f91a2b7).
⚠️ Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #235   +/-   ##
========================================
  Coverage    77.71%   77.71%           
========================================
  Files           96       96           
  Lines         7298     7298           
  Branches      1787     1787           
========================================
  Hits          5672     5672           
  Misses        1108     1108           
  Partials       518      518           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fc8c97...f91a2b7. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cppalliance-bot
Copy link
Copy Markdown

GCOVR code coverage report https://235.corosio.prtest3.cppalliance.org/gcovr/index.html
LCOV code coverage report https://235.corosio.prtest3.cppalliance.org/genhtml/index.html
Coverage Diff Report https://235.corosio.prtest3.cppalliance.org/diff-report/index.html

Build time: 2026-04-17 20:25:32 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants