Skip to content

Fixed dotfile mv in pkg-build-deb picking up . and .. #2164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
larsewi merged 1 commit into from
Apr 17, 2026
+7 −2
Merged

Fixed dotfile mv in pkg-build-deb picking up . and .. #2164

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions deps-packaging/pkg-build-deb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,13 @@ echo "$SRCFILES" | while read srcfile opts; do
mkdir -p "$TD"
$UNCOMPRESS $srcfile | tar -C $TD -xf -
mv $TD/*/* $PKGDIR
# Also move dot files, but don't fail if there are none
mv $TD/*/.* $PKGDIR || true
# Also move dot files (.gitignore, etc.), skipping . and ..
for _dotfile in $TD/*/.*; do
case "${_dotfile##*/}" in
Copy link
Copy Markdown
Contributor

@craigcomstock craigcomstock Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interestingly, how is this bash expression different than basename? Using basename might be more immediately understandable to more folks.

.|..) continue ;;
*) mv "$_dotfile" "$PKGDIR" ;;
esac
done
rm -r "$TD"
fi
done
Expand Down
Loading